Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill ScrollView when content is smaller than viewport #7514

Merged
merged 22 commits into from
Jun 9, 2022
Merged

Fill ScrollView when content is smaller than viewport #7514

merged 22 commits into from
Jun 9, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented May 26, 2022

Description of Change

When the content of MAUI ScrollViews is less than the size of the viewport and the content is set to Fill, the content remains at the small size rather than filling the viewport. These changes ensure that the content fills the viewport of the ScrollView on each platform.

This also moves several of the automated ScrollView unit tests to device tests (since differences in the platform ScrollView implementations mean that the actual layout of ScrollView content is platform-dependent).

Finally, this adds an actual vertical content alignment to the iOS Label implementation; the previous implementation (which attempted to align the content by adjusting the UILabel's Frame) caused complications and bugs with nested content (e.g., a Label with a Background inside a ScrollView).

Issues Fixed

Fixes #6058
Fixes #6694

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label May 26, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this will require an update to the publicapi.txt, but testing to see how to do a remove.

-public override void PlatformArrange(Rect frame)
+public override Size GetDesiredSize(double widthConstraint, double heightConstraint)

@hartez hartez requested a review from mattleibow June 9, 2022 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants