Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the FlyoutBehavior is "Flyout" show toolbar #7544

Merged
merged 1 commit into from
May 27, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

Shell isn't correctly taking into account the Flyoutbehavior value when determining if the Toolbar should be visible.

This means if the user hasn't specified any ToolbarItems or a Title but they still want the Hamburger Menu they weren't getting it. This PR fixes that.

@PureWeen PureWeen requested a review from SotoiGhost May 27, 2022 17:09
@PureWeen PureWeen added this to the 6.0.3xx-sr1 milestone May 27, 2022
@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label May 27, 2022
Copy link
Contributor

@SotoiGhost SotoiGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@PureWeen PureWeen enabled auto-merge (squash) May 27, 2022 18:12
@PureWeen PureWeen merged commit 1a562f4 into main May 27, 2022
@PureWeen PureWeen deleted the fix_flyout_menu_visibility branch May 27, 2022 18:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants