Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GridLayoutManager Layout calculation #7712

Merged
merged 2 commits into from Jun 23, 2022
Merged

Fix GridLayoutManager Layout calculation #7712

merged 2 commits into from Jun 23, 2022

Conversation

myroot
Copy link
Contributor

@myroot myroot commented Jun 2, 2022

Description of Change

Replaced widthConstraint/heightConstraint to explicit width/height, if explicit width/height was valid.

GridlayoutManager returns the explicit width/height as a measure result if it was valid

var height = _explicitGridHeight > -1 ? _explicitGridHeight : GridHeight();

var width = _explicitGridWidth > -1 ? _explicitGridWidth : GridWidth();

But, Layout calculation was not affected by explicit width/height. so, ArrangeChildren is not working propertly
It was fixed

Issues Fixed

Fixes #7681

Fix calculation of cell size to reflect explicit view size
@hartez hartez self-requested a review June 2, 2022 22:54
@jsuarezruiz jsuarezruiz added the area-layout StackLayout, GridLayout, ScrollView, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jun 3, 2022
@rmarinho
Copy link
Member

rmarinho commented Jun 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hartez hartez added this to the 6.0-sr2 milestone Jun 6, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@hartez hartez self-assigned this Jun 7, 2022
@jfversluis jfversluis added the community ✨ Community Contribution label Jun 16, 2022
@hartez hartez changed the base branch from main to net6.0 June 23, 2022 15:13
@hartez hartez merged commit 6b9c986 into dotnet:net6.0 Jun 23, 2022
@myroot myroot deleted the patch-2 branch August 4, 2022 07:44
@myroot myroot restored the patch-2 branch August 4, 2022 07:44
@myroot myroot deleted the patch-2 branch August 4, 2022 07:44
@myroot myroot restored the patch-2 branch August 4, 2022 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ScrollView, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GridLayoutManager] if IGridLayout.Width/Height was valid, ArrangeChildren was not properly working
5 participants