Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CheckBox's VisualStates #8605

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Fix CheckBox's VisualStates #8605

merged 5 commits into from
Sep 12, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix CheckBox's VisualStates. Propagate CheckBox Color property changes to handlers.

fix-8596

Issues Fixed

Fixes #8596

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-checkbox CheckBox labels Jul 8, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 8, 2022
@jsuarezruiz jsuarezruiz added this to the 6.0-servicing milestone Jul 11, 2022
mattleibow
mattleibow reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

@jsuarezruiz
Copy link
Contributor Author

Is it possible to add a test for this?

Added a Device Test.

@Redth Redth modified the milestones: 6.0-servicing, .NET 7 Planning Aug 30, 2022
@jsuarezruiz jsuarezruiz mentioned this pull request Sep 6, 2022
Closed
@rmarinho rmarinho merged commit 6f92b8c into net6.0 Sep 12, 2022
@rmarinho rmarinho deleted the fix-8596 branch September 12, 2022 11:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow left review comments

@rmarinho rmarinho rmarinho approved these changes

Assignees
No one assigned
Labels
area-controls-checkbox CheckBox t/bug Something isn't working
Projects
None yet
Milestone
.NET 7 Planning
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsuarezruiz @mattleibow @rmarinho @Eilon @Redth