Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell] Fixes for Shell issues with iOS and Mac #8618

Merged
merged 2 commits into from Jul 13, 2022
Merged

[Shell] Fixes for Shell issues with iOS and Mac #8618

merged 2 commits into from Jul 13, 2022

Conversation

SotoiGhost
Copy link
Contributor

@SotoiGhost SotoiGhost commented Jul 9, 2022

Description of Change

  • .jpg files do not contain a context; let's use the Shell context when an image does not have one
  • The accessory view of the Search bar was trying to change its flow direction when null, that does not seem right

Issues Fixed

Fixes #7260

@jsuarezruiz jsuarezruiz added partner/macios Issues for the Mac / iOS SDK area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout labels Jul 11, 2022
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Israel Soto added 2 commits July 11, 2022 17:49
* Do not change the numericAccessoryView flow layout if null
* It seems that jpg files do not contain the Maui context, let's use the App Maui context when the object does not contain a context
@SotoiGhost SotoiGhost requested a review from PureWeen July 11, 2022 22:51
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen merged commit 65f0889 into dotnet:net6.0 Jul 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/shell 🐢 Shell Navigation, Routes, Tabs, Flyout partner/macios Issues for the Mac / iOS SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants