Fix [Android] CollectionView EmptyView SelectionMode=Single on Android #9215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @yurkinh! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jfversluis
added
the
area-controls-collectionview
salarcode
reviewed
Aug 8, 2022
src/Controls/src/Core/Platform/Android/Extensions/RecyclerViewExtensions.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
approved these changes
Aug 8, 2022
|
We cold just check on line 16 and return there if it's null, so no other code will run if there's no adapter |
hartez
approved these changes
Aug 9, 2022
|
/azp run |
rmarinho
approved these changes
Aug 10, 2022
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yurkinh there has been a misunderstanding I'm not a reviewer, I think someone else should review this. Although everything seems good to me :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
If an empty view is used in a collection view with a single selection mode and there is no Item in the list on startup the app crashes on Android. Works fine on ios/Windows.
Fixes #9060