Shell Android Handler #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
D:\repos\dotnet\maui\src\Controls\src\Core\Platform\Android\Shell\ShellContentFragment.cs(16,85): error CS0246: The t |
PureWeen
force-pushed
the
shell_android
branch
2 times, most recently
from
2e94ad6
to
46896a3
Compare
PureWeen
commented
May 18, 2021
| Platform.Android.AppCompat.Platform.SetRenderer( | ||
| VisualElementRenderer.Element, | ||
| null); | ||
| if (VisualElementRenderer.Element != null) |
There was a problem hiding this comment.
If the renderer has already been cleared then don't try to clear it again
PureWeen
commented
May 18, 2021
|
|
||
| namespace Microsoft.Maui.Controls.Compatibility.Platform.Android | ||
| { | ||
| public interface IShellContext | ||
| public interface IShellContext : Microsoft.Maui.Controls.Platform.IShellContext |
There was a problem hiding this comment.
This will allow peoples custom shell renderers to shim and register correctly
PureWeen
commented
May 18, 2021
| @@ -272,7 +272,7 @@ protected virtual void SwitchFragment(FragmentManager manager, AView targetView, | |||
| FragmentTransaction transaction = manager.BeginTransactionEx(); | |||
|
|
|||
| if (animate) | |||
| transaction.SetTransitionEx((int)global::Android.App.FragmentTransit.EnterMask); | |||
| transaction.SetTransitionEx((int)global::Android.App.FragmentTransit.FragmentOpen); | |||
There was a problem hiding this comment.
This is to fix a crash that happens on newer versions of AndroidX
PureWeen
force-pushed
the
shell_android
branch
3 times, most recently
from
1a75876
to
7dfc9dc
Compare
PureWeen
commented
Jul 3, 2021
| @@ -20,20 +21,5 @@ public FormsViewPager(Context context, IAttributeSet attrs) : base(context, attr | |||
| protected FormsViewPager(IntPtr javaReference, JniHandleOwnership transfer) : base(javaReference, transfer) | |||
| { | |||
| } | |||
|
|
|||
| public bool EnableGesture { get; set; } = true; | |||
There was a problem hiding this comment.
These are all inside MauiViewPager now
PureWeen
force-pushed
the
shell_android
branch
2 times, most recently
from
a533492
to
7863dec
Compare
PureWeen
force-pushed
the
shell_android
branch
2 times, most recently
from
78078cb
to
caf0c42
Compare
Redth
approved these changes
Jul 23, 2021
pjcollins
pushed a commit
that referenced
this pull request
Jul 23, 2021
* Android Shell Handler * - fix resource references on compatibility
samhouts
added
platform/android 🤖
area/shell 🐢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Move Android Shell implementation, and related classes, into Controls.Core
Manage your expectations a bit on this one. This is mainly to get Shell inside the Maui.Controls library and then we can start fixing issues
Known Issues
The flyout items don't layout correctly because of
#746
#1049