Allow string property binding as Color source #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
jsuarezruiz
commented
Aug 31, 2022
| @@ -41,6 +41,7 @@ public sealed class BindableProperty | |||
| static readonly Dictionary<Type, TypeConverter> KnownTypeConverters = new Dictionary<Type, TypeConverter> | |||
| { | |||
| { typeof(Uri), new UriTypeConverter() }, | |||
| { typeof(Maui.Graphics.Color), new ColorTypeConverter() }, | |||
There was a problem hiding this comment.
This is the main change.
There was a problem hiding this comment.
That list is only for types we can’t attribute. Don’t we have a converter attribute on colour?
There was a problem hiding this comment.
Talked about this with Stephane and is ok to merge, Shane could you review it again?
This was referenced Aug 31, 2022
|
can we add a xaml test? |
hartez
previously approved these changes
Nov 23, 2022
|
Doesn’t look like the correct way to fix this |
hartez
dismissed
their stale review
Stephane knows more about this than I do :)
Could you share more details?. Thanks! |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
approved these changes
Jan 31, 2023
mandel-macaque
approved these changes
Feb 17, 2023
jsuarezruiz
requested review from
PureWeen and
StephaneDelcroix
and removed request for
PureWeen,
hartez and
StephaneDelcroix
StephaneDelcroix
approved these changes
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Allow string property binding as Color source.
Issues Fixed
Fixes #9662
Fixes #8390
Fixes #7683