Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AspNet.Security.OAuth.Apple to 6.0.10 #9855

Merged
merged 1 commit into from Sep 2, 2022

Conversation

martincostello
Copy link
Member

Description of Change

Bump AspNet.Security.OAuth.Apple to 6.0.10 in the WebAuthenticator sample to resolve GHSA-3893-h8qg-6h5f.

Bump AspNet.Security.OAuth.Apple to 6.0.10 to resolve GHSA-3893-h8qg-6h5f.
@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Sep 1, 2022
@rmarinho
Copy link
Member

rmarinho commented Sep 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@martincostello
Copy link
Member Author

I think someone from your infra team will need to add this package to your internal mirror of NuGet.org.

@rmarinho
Copy link
Member

rmarinho commented Sep 2, 2022

yap i asked @martincostello is already there going to rerun these

@rmarinho
Copy link
Member

rmarinho commented Sep 2, 2022

@martincostello this fix will probabily only go to net7.rc2, do you want to make this against net6.0 we just shipped sr5, but if we have a sr6 it will be there

@martincostello
Copy link
Member Author

I guess that depends what the use case for this is. If people regularly fork the repo/copy the code to produce applications from, then it's sort of propagating the problem further if not fixed at the source.

It would be good to also patch the 6.0 branch if this package "ships" in some way via the sample.

I sort of ended up here via looking at the package dependencies in GitHub and finding all these repos that have been forked from other people's templates that use this library:

image

The source of many of the forks is this enkodellc/blazorboilerplate repo, which already has a PR open with the fix: enkodellc/blazorboilerplate#922

@rmarinho
Copy link
Member

rmarinho commented Sep 2, 2022

Oh right, we don't ship this sorry, it's just on the sample app.

@rmarinho rmarinho merged commit 9bdd13b into dotnet:main Sep 2, 2022
@martincostello martincostello deleted the patch-1 branch September 2, 2022 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants