[net6.0][Core]Fixes wrong declared CommandMapper types #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @myroot! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
myroot
changed the title
jsuarezruiz
approved these changes
Sep 6, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Can you retarget this pr to release/6.0.5xx-sr5? Then we can get into the upcoming release. |
Sure |
myroot
force-pushed
the
fix-wrong-command-mapper-type
branch
from
563663b
to
f0c85d8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rmarinho
reviewed
Sep 8, 2022
There was a problem hiding this comment.
@mattleibow i think the API changes are wrong no? we should add on unshipped ? the ***REMOVE and add the new API
|
Ah yeah |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Some Handlers are using missmatched types on
CommandMapper. It makes me hard to add command mapper so I fix itfor example
maui/src/Core/src/Handlers/IndicatorView/IndicatorViewHandler.cs
Line 31 in f0a814c
IndicatorView must use IIndicatorView type as VirtualView type but it use IActivityIndicator,
I think, It seems mistake. if it is not mistake, let me know