Don't Propagate Command Mappers when Android View is Disposed of #9956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
force-pushed
the
dont_propagate_command_mappers
branch
from
e4849fd
to
8064cb9
Compare
jsuarezruiz
approved these changes
Sep 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
approved these changes
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We already have code inside the property mapper to not propagate when the android view is disposed. We should have the same code inside the CommandMapper. If you run the device tests enough times you'll hit a crash from the command mapper invoking on a disposed unmanaged peer