Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Mar 14, 2024

Fix the warning from build #39
9766

msbuild-api-docs/xml/Microsoft.Build.Construction/ProjectRootElement.xml
Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Build.Construction.ProjectRootElement.MarkDirty(System.String,System.String)'.

msbuild-api-docs/xml/Microsoft.Build.Framework.XamlTypes/BaseProperty.xml
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'seealso' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

msbuild-api-docs/xml/Microsoft.Build.Framework/BuildEventArgs.xml
Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Build.Framework.BuildEventArgs.timestamp'.

msbuild-api-docs/xml/Microsoft.Build.Framework/CustomBuildEventArgs.xml
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

Copy link

Learn Build status updates of commit 627b9ed:

✅ Validation status: passed

File Status Preview URL Details
msbuild-api-docs/xml/Microsoft.Build.Construction/ProjectRootElement.xml ✅Succeeded View
msbuild-api-docs/xml/Microsoft.Build.Framework.XamlTypes/BaseProperty.xml ✅Succeeded View
msbuild-api-docs/xml/Microsoft.Build.Framework/BuildEventArgs.xml ✅Succeeded View
msbuild-api-docs/xml/Microsoft.Build.Framework/CustomBuildEventArgs.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@JaynieBai JaynieBai marked this pull request as ready for review March 14, 2024 07:39
@MichalPavlik
Copy link

MichalPavlik commented Mar 14, 2024

@JaynieBai, sorry for the confusion. These XMLs are generated automatically from xmldoc in our source, so we should make changes there. For example reference to the internal member MarkDirty should be fixed at https://github.com/dotnet/msbuild/blob/main/src/Build/Construction/ProjectRootElement.cs#L1652.

@ghogen, does it make sense to update XMLs before next release? And is there some Roslyn Analyzer that would allow us to catch these warnings/errors early?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants