Skip to content

Commit

Permalink
Skip TestItemsWithUnexpandableMetadata
Browse files Browse the repository at this point in the history
Issue #6518 is tracking.

More work is needed to understand the desired behavior of the system under test and then fix the test to test the desired behavior.
  • Loading branch information
KirillOsenkov committed Jun 15, 2021
1 parent 55be3a5 commit 264a797
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Build.UnitTests/ConsoleLogger_Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ public void ErrorMessageWithMultiplePropertiesInMessage(bool includeEvaluationPr
output.ShouldContain("source_of_error : error : Hello from project 2 [" + project.ProjectFile + ":: Number=2 TargetFramework=netcoreapp2.1]");
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/msbuild/issues/6518")]
[SkipOnTargetFramework(TargetFrameworkMonikers.Netcoreapp, "Minimal path validation in Core allows expanding path containing quoted slashes.")]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "Minimal path validation in Mono allows expanding path containing quoted slashes.")]
public void TestItemsWithUnexpandableMetadata()
Expand All @@ -338,7 +338,8 @@ public void TestItemsWithUnexpandableMetadata()
<Target Name=""X"" />
</Project>", logger);

sc.ToString().ShouldContain("\"a\\b\\%(Filename).c\"");
var text = sc.ToString();
text.ShouldContain("\"a\\b\\%(Filename).c\"");
}

/// <summary>
Expand Down

0 comments on commit 264a797

Please sign in to comment.