SA1010 Opening square brackets should not be preceded by a space (#7205)

* SA1010 Opening square brackets should not be preceded by a space * revert changes to deprecated * enable warning on SA1010
dotnet · Jan 10, 2022 · 3a08478 · 3a08478
1 parent 8c450f1
commit 3a08478
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/eng/Common.globalconfig b/eng/Common.globalconfig
@@ -726,7 +726,7 @@ dotnet_diagnostic.SA1008.severity = suggestion
 dotnet_diagnostic.SA1009.severity = suggestion
 
 # Opening square brackets should not be preceded by a space
-dotnet_diagnostic.SA1010.severity = suggestion
+dotnet_diagnostic.SA1010.severity = warning
 
 # Closing square bracket should be followed by a space
 dotnet_diagnostic.SA1011.severity = suggestion

diff --git a/src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs b/src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
@@ -1057,7 +1057,7 @@ private bool ProcessBodyBytesRead(int bytesRead, int packetLength, NodePacketTyp
                 return true;
             }
 
-            private bool ReadAndRoutePacket(NodePacketType packetType, byte [] packetData, int packetLength)
+            private bool ReadAndRoutePacket(NodePacketType packetType, byte[] packetData, int packetLength)
             {
                 try
                 {

diff --git a/src/MSBuild/XMake.cs b/src/MSBuild/XMake.cs
@@ -212,7 +212,7 @@ private static void HandleConfigurationException(Exception ex)
         [MTAThread]
         public static int Main(
 #if !FEATURE_GET_COMMANDLINE
-            string [] args
+            string[] args
 #endif
             )
         {
@@ -482,7 +482,7 @@ private static string GetFriendlyCounterType(PerformanceCounterType type, string
 #if FEATURE_GET_COMMANDLINE
             string commandLine
 #else
-            string [] commandLine
+            string[] commandLine
 #endif
             )
         {
@@ -1615,7 +1615,7 @@ internal static void SetConsoleUI()
 #if FEATURE_GET_COMMANDLINE
             string commandLine,
 #else
-            string [] commandLine,
+            string[] commandLine,
 #endif
             out CommandLineSwitches switchesFromAutoResponseFile, out CommandLineSwitches switchesNotFromAutoResponseFile)
         {

diff --git a/src/Tasks/CombineXmlElements.cs b/src/Tasks/CombineXmlElements.cs
@@ -21,7 +21,7 @@ public class CombineXmlElements : TaskExtension
         /// <summary>
         /// The XML elements to include as children of the root element
         /// </summary>
-        public ITaskItem [] XmlElements { get; set; }
+        public ITaskItem[] XmlElements { get; set; }
 
         /// <summary>
         /// The generated XML