Skip to content

Commit

Permalink
Fix after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
JanKrivanek committed May 3, 2024
1 parent 3c6ebd4 commit 55c00ec
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ private string BuildCsvString(string title, Dictionary<string, TimeSpan> rowData
{ typeof(ProjectEvaluationFinishedEventArgs), (BuildEventArgs e) => HandleProjectEvaluationFinishedEvent((ProjectEvaluationFinishedEventArgs) e) },
{ typeof(ProjectEvaluationStartedEventArgs), (BuildEventArgs e) => HandleProjectEvaluationStartedEvent((ProjectEvaluationStartedEventArgs) e) },
{ typeof(ProjectStartedEventArgs), (BuildEventArgs e) => _buildCheckManager.StartProjectRequest(BuildCheckDataSource.EventArgs, e.BuildEventContext!) },
{ typeof(ProjectFinishedEventArgs), (BuildEventArgs e) => _buildCheckManager.EndProjectRequest(BuildCheckDataSource.EventArgs, e.BuildEventContext!) },
{ typeof(ProjectFinishedEventArgs), (BuildEventArgs e) => _buildCheckManager.EndProjectRequest(BuildCheckDataSource.EventArgs, e.BuildEventContext!, (e as ProjectFinishedEventArgs)!.ProjectFile!) },
{ typeof(BuildCheckTracingEventArgs), (BuildEventArgs e) =>
{
if(!((BuildCheckTracingEventArgs)e).IsAggregatedGlobalReport)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using Microsoft.Build.BuildCheck.Acquisition;
using Microsoft.Build.BuildCheck.Analyzers;
using Microsoft.Build.BuildCheck.Logging;
using Microsoft.Build.Evaluation;
using Microsoft.Build.Experimental.BuildCheck;
using Microsoft.Build.Framework;
using Microsoft.Build.Shared;
Expand Down Expand Up @@ -64,7 +65,7 @@ public void InitializeComponent(IBuildComponentHost host)

public void ShutdownComponent() => GlobalInstance.Shutdown();

private sealed class BuildCheckManager : IBuildCheckManager, IBuildEngineDataConsumer
internal sealed class BuildCheckManager : IBuildCheckManager, IBuildEngineDataConsumer
{
private readonly TracingReporter _tracingReporter = new TracingReporter();
private readonly BuildCheckCentralContext _buildCheckCentralContext = new();
Expand Down
15 changes: 0 additions & 15 deletions src/Build/Evaluation/Expander.cs
Original file line number Diff line number Diff line change
Expand Up @@ -379,21 +379,6 @@ internal Expander(IPropertyProvider<P> properties, IItemProvider<I> items, Evalu
_items = items;
}

/// <summary>
/// Initializes a new instance of the <see cref="Expander{P, I}"/> class with the specified property provider, item provider, evaluation context, and logging context.
/// </summary>
/// <param name="properties">The property provider supplying properties for expansion.</param>
/// <param name="items">The item provider supplying items for expansion.</param>
/// <param name="evaluationContext">The evaluation context used during expansion.</param>
/// <param name="loggingContext">The logging context used for logging or emmitting events during expansion.</param>
/// <exception cref="ArgumentNullException">Thrown when either <paramref name="properties"/> or <paramref name="evaluationContext"/> is null.</exception>
internal Expander(IPropertyProvider<P> properties, IItemProvider<I> items, EvaluationContext evaluationContext, LoggingContext loggingContext)
: this(properties, evaluationContext)
{
_items = items;
_loggingContext = loggingContext;
}

/// <summary>
/// Creates an expander passing it some properties, items, and/or metadata to use.
/// Any or all may be null.
Expand Down

0 comments on commit 55c00ec

Please sign in to comment.