Change help to use hyphen switches and consistent casing

src/MSBuild.UnitTests/CommandLineSwitches_Tests.cs

@@ -1223,7 +1223,7 @@ public void ProcessNodeReuseSwitchFalseLast()
 #endif
 
         /// <summary>
-        /// Regress DDB #143341: 
+        /// Regress DDB #143341:
         ///     msbuild /clp:v=quiet /clp:v=diag /m:2
         /// gave console logger in quiet verbosity; expected diagnostic
         /// </summary>
@@ -1329,7 +1329,7 @@ public void ProcessWarnAsErrorSwitchEmpty()
             CommandLineSwitches commandLineSwitches = new CommandLineSwitches();
 
             MSBuildApp.GatherCommandLineSwitches(new ArrayList(new [] { "/warnaserror" }), commandLineSwitches);
-            
+
             ISet<string> actualWarningsAsErrors = MSBuildApp.ProcessWarnAsErrorSwitch(commandLineSwitches);
 
             Assert.NotNull(actualWarningsAsErrors);
@@ -1447,9 +1447,11 @@ public void HelpMessagesAreValid()
                     // All lines should be 80 characters or less
                     Assert.True(helpMessageLines[i].Length <= 80, $"Line {i + 1} of '{item.Key}' should be no longer than 80 characters.");
 
+                    string trimmedLine = helpMessageLines[i].Trim();
+
                     if (i == 0)
                     {
-                        if (helpMessageLines[i].Trim().StartsWith("/") || helpMessageLines[i].Trim().StartsWith("@"))
+                        if (trimmedLine.StartsWith("-") || trimmedLine.StartsWith("@"))
                         {
                             // If the first line in a switch it needs a certain amount of leading spaces
                             Assert.True(helpMessageLines[i].StartsWith(switchLeadingSpaces), $"Line {i + 1} of '{item.Key}' should start with '{switchLeadingSpaces}'.");
@@ -1465,13 +1467,13 @@ public void HelpMessagesAreValid()
                         // Ignore empty lines
                         if (!String.IsNullOrWhiteSpace(helpMessageLines[i]))
                         {
-                            
+
                             if (item.Key.Contains("Examples"))
                             {
                                 // Examples require a certain number of leading spaces
                                 Assert.True(helpMessageLines[i].StartsWith(examplesLeadingSpaces), $"Line {i + 1} of '{item.Key}' should start with '{examplesLeadingSpaces}'.");
                             }
-                            else if (helpMessageLines[i].Trim().StartsWith("/") || helpMessageLines[i].Trim().StartsWith("@"))
+                            else if (trimmedLine.StartsWith("-") || trimmedLine.StartsWith("@"))
                             {
                                 // Switches require a certain number of leading spaces
                                 Assert.True(helpMessageLines[i].StartsWith(switchLeadingSpaces), $"Line {i + 1} of '{item.Key}' should start with '{switchLeadingSpaces}'.");