Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdk imports broken in latest build. #2034

Closed
srivatsn opened this issue May 1, 2017 · 3 comments
Closed

Sdk imports broken in latest build. #2034

srivatsn opened this issue May 1, 2017 · 3 comments
Labels
triaged
Milestone
MSBuild 15.3

Comments

@srivatsn
Copy link
Contributor

srivatsn commented May 1, 2017

Install D15PreRel 26427.3
Create a project like this:

<Project>
  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />

  <PropertyGroup>
    <TargetFramework>netstandard1.6</TargetFramework>
  </PropertyGroup>
  
  <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />
</Project>

msbuild fails with:

C:\Users\srivatsn\Documents\Visual Studio 2017\Projects\ClassLibrary9\ClassLibrary9\ClassLibrary9.csproj" (default tar
get) (1) ->
  C:\Users\srivatsn\Documents\Visual Studio 2017\Projects\ClassLibrary9\ClassLibrary9\ClassLibrary9.csproj(3,3): error
MSB4019: The imported project "C:\Users\srivatsn\Documents\Visual Studio 2017\Projects\ClassLibrary9\ClassLibrary9\Sdk.
props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.
@dsplaisted
Copy link
Member

Is this because the right SDK resolvers haven't been added yet?

@srivatsn
Copy link
Contributor Author

srivatsn commented May 1, 2017

<Project Sdk=Microsoft.NET.Sdk> works. Also the sdks are still available in the msbuild location - so the default resolver should pick up the SDK and does for the project-style import

@AndyGerlicher
Copy link
Contributor

Yeah this is a bug. Looks like there were no unit tests covering <Import> with SDK :(

AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue May 1, 2017
@AndyGerlicher
Fix issue importing an SDK via Import element.
eee8f6e 
* This feature was regressed in dotnet#2002
* Update unit tests to verify functionality
* Update ProjectParse to parse values and construct an SdkReference object to be used by the evaluator.

Closes dotnet#2034
AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue May 1, 2017
@AndyGerlicher
Fix issue importing an SDK via Import element.
4a7c87d 
* This feature was regressed in dotnet#2002
* Update unit tests to verify functionality
* Update ProjectParser to parse values and construct an SdkReference object to be used by the evaluator.

Closes dotnet#2034
AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue May 1, 2017
@AndyGerlicher
Fix issue importing an SDK via Import element.
ecb2dae 
* This feature was regressed in dotnet#2002
* Update unit tests to verify functionality
* Update ProjectParser to parse SDK name/version values and construct an SdkReference object to be used by the evaluator.

Closes dotnet#2034
@AndyGerlicher AndyGerlicher mentioned this issue May 1, 2017
Merged
AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue May 1, 2017
@AndyGerlicher
Fix issue importing an SDK via Import element.
8993c2b 
* This feature was regressed in dotnet#2002
* Update unit tests to verify functionality
* Update ProjectParser to parse SDK name/version values and construct an SdkReference object to be used by the evaluator.

Closes dotnet#2034
@rainersigwald rainersigwald mentioned this issue May 2, 2017
Closed
@AndyGerlicher AndyGerlicher modified the milestone: MSBuild 15.3 May 2, 2017
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
MSBuild 15.3
Development

No branches or pull requests
4 participants
@srivatsn @dsplaisted @AndyGerlicher @AR-May