Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party pdb files not copied to build output #2920

Closed
ctaggart opened this issue Jan 27, 2018 · 2 comments
Closed

3rd party pdb files not copied to build output #2920

ctaggart opened this issue Jan 27, 2018 · 2 comments
Labels

Comments

@ctaggart
Copy link

ctaggart commented Jan 27, 2018

Expected behavior

The 3rd party pdb files are copied to the build output for .NET Framework projects like they used to be before .NET Core project format. Is there a property I can set to get this? Is there a similar property to:

<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>

Actual behavior

The 3rd party pdb file is not copied. In this case, there is a Newtonsoft.Json.pdb that should be copied, but is not.
image

Using the same nupkg with the old format ends up copying the pdb file:
image

In order to debug into source link enabled libraries, the pdb files need to be copied.

Steps to reproduce

git clone -b msbuild2920 https://github.com/ctaggart/sourcelink-test.git msbuild2920
cd msbuild2920
.\TryJson.sln

Environment data

C:\Users\camer\cs\sourcelink-test [json ≡ +2 ~0 -0 !]> dotnet --info
.NET Command Line Tools (2.1.4)

Product Information:
 Version:            2.1.4
 Commit SHA-1 hash:  5e8add2190

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.16299
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\2.1.4\

Microsoft .NET Core Shared Framework Host

  Version  : 2.0.5
  Build    : 17373eb129b3b05aa18ece963f8795d65ef8ea54
ctaggart added a commit to ctaggart/sourcelink-test that referenced this issue Jan 27, 2018
@ctaggart ctaggart changed the title 3rd party pdb files not copied to build output for 3rd party pdb files not copied to build output Jan 27, 2018
@dasMulli
Copy link
Contributor

Looks like a duplicate of dotnet/sdk#1458
cc @nguerrera

@ctaggart
Copy link
Author

It is a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants