Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling XML comment warnings (1591,1573) when run against a .sln #47

Closed
lilith opened this issue Mar 28, 2015 · 3 comments
Closed
Assignees
Labels

Comments

@lilith
Copy link

lilith commented Mar 28, 2015

MSBuild does not currently offer any way to pass-through properties to the projects within a .sln file.

Despite the documentation, properties provided at the command line with a solution file are ignored.

This makes it very difficult to disable XML warnings on a CI server in order to reduce output noise. Many developers feel that 30% of their lines of code should not be /// <summary>, and that code noise (like output noise) must be justified .

@Craig-Campbell-MS
Copy link
Contributor

@nathanaeljones I just created a project and a solution and I was able to pass through a property /p:A=B to the project while building the solution file. Can you expand on what you'd like to see? Thx

@lilith
Copy link
Author

lilith commented Mar 31, 2015

@jeffkl jeffkl self-assigned this Nov 22, 2016
@jeffkl
Copy link
Contributor

jeffkl commented Nov 22, 2016

I'll be fixing this soon with #68

jeffkl added a commit that referenced this issue Nov 29, 2016
You cannot suppress all warnings, if you specify empty `/warnasmessage` or `/nowarn`, you get an error message.
Warnings are mutated into just a message.
Ignore the first commit which is the implementation of /WarnAsError

Closes #68
Closes #47
Closes #910 

So this:
```
MyProject.proj(3,18): warning MSB4130: The condition "true or true and true" may have been evaluated incorrectly 
in an earlier version of MSBuild. Please verify that the order of the AND and OR clauses is written as intended. To 
avoid this warning, add parentheses to make the evaluation order explicit.
```
Becomes this in with Verbosity=Detailed 
```
MyProject.proj(3,18): message MSB4130: The condition "true or true and true" may have been evaluated incorrectly
in an earlier version of MSBuild. Please verify that the order of the AND and OR clauses is written as intended. To
avoid this warning, add parentheses to make the evaluation order explicit.
```

Here is the help message for review:
```
  /warnasmessage[:code[;code2]]
                     List of warning codes to treats as low importance
                     messages.  Use a semicolon or a comma to separate
                     multiple warning codes.
                     (Short form: /nowarn[:c;[c2]])

                     Example:
                       /warnasmessage:MSB3026
```
radical added a commit to radical/msbuild that referenced this issue May 3, 2018
We are still setting `_DebugFileExt` to `.mdb` if `vbnc` is used,
because this is a mono specific property for now and we still bundle
`vbnc*`.

Also, not setting `UseSharedCompilation` any more as it doesn't seem to
be required now.

Setting `VbcToolExe` and `VbcToolPath` should allow using `vbnc`.

Fixes: mono/mono#7756
(cherry picked from commit 93531d6)
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants