Possible null-dereference

[wuestholz]

There seems to be a possible null-dereference here.

The code below seems like a sensible fix:

DependentPlatforms = new List<DependentPlatform>();
ApiContracts = new List<ApiContract>();

if (rootElement != null)
{
    Name = rootElement.GetAttribute(Attributes.Name);
    FriendlyName = rootElement.GetAttribute(Attributes.FriendlyName);
    PlatformVersion = rootElement.GetAttribute(Attributes.Version);

    foreach (XmlNode childNode in rootElement.ChildNodes)
    {
        XmlElement childElement = childNode as XmlElement;
        if (childElement == null)
        {
            continue;
        }

        if (ApiContract.IsContainedApiContractsElement(childElement.Name))
        {
            ApiContract.ReadContractsElement(childElement, ApiContracts);
        }
        else if (String.Equals(childElement.Name, Elements.DependentPlatform, StringComparison.Ordinal))
        {
            DependentPlatforms.Add(new DependentPlatform(childElement.GetAttribute(Attributes.Name), childElement.GetAttribute(Attributes.Version)));
        }
    }
}

[rainersigwald]

Agreed, and your fix looks reasonable to me. Would you like to submit a pull request?

[wuestholz]

@rainersigwald Great! Thanks for having a look. I just created a PR.

[cdmihai]

LGTM.
Minor comment: is it or is it not an error if the xml file is there but the root element is not found?