Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NuGet restore / assets file reading to MSBuild #5757

Open
dsplaisted opened this issue Sep 29, 2020 · 1 comment
Open

Add support for NuGet restore / assets file reading to MSBuild #5757

dsplaisted opened this issue Sep 29, 2020 · 1 comment
Labels
For consideration Used for items on the backlog to raise them to the top of that list for discussion needs-design Requires discussion with the dev team before attempting a fix. Partner request triaged
Milestone

Comments

@dsplaisted
Copy link
Member

Support for NuGet PackageReference restore and build is currently spread across NuGet.targets and the .NET SDK. This prevents non .NET projects from supporting NuGet PackageReference.

We would like to make NuGet PackageReference available to all MSBuild projects. That includes the following:

  • Targets required to send data to NuGet (nomination)
    • Mostly works, apart from setting assets file path
  • Targets required to make restore work from the command line - these already seem to be imported from common targets
  • Targets required to make dependency node work
    • Read data from assets file and return dependencies (now only top-level dependencies)
  • Targets required to make build work
    • Reading assets file, create appropriate items (ie Content) from assets file
@dsplaisted dsplaisted added Partner request For consideration Used for items on the backlog to raise them to the top of that list for discussion needs-triage Have yet to determine what bucket this goes in. labels Sep 29, 2020
@benvillalobos benvillalobos added the needs-design Requires discussion with the dev team before attempting a fix. label Sep 30, 2020
@marcpopMSFT marcpopMSFT added this to the MSBuild 16.10 milestone Oct 2, 2020
@rainersigwald rainersigwald removed the needs-triage Have yet to determine what bucket this goes in. label Oct 7, 2020
@rainersigwald rainersigwald modified the milestones: MSBuild 16.10, 17.0 May 27, 2021
@marcpopMSFT marcpopMSFT modified the milestones: 17.0, MSBuild 17.1 Jul 9, 2021
@marcpopMSFT marcpopMSFT modified the milestones: VS 17.1, VS 18.0 Jan 7, 2022
@abatishchev
Copy link

abatishchev commented May 19, 2023

+1. I have an msbuild project which uses ProjectReference with a NuGet package that includes MSBuild targets/props such as:

and which isn't a .NET project, nor produces any binary assets, but JSON.

Currently the experience in VS is poor: when the packages are restored, the package isn't included into project.assets.json, nor its target/props into the build process. Unlike dotnet restore where it works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For consideration Used for items on the backlog to raise them to the top of that list for discussion needs-design Requires discussion with the dev team before attempting a fix. Partner request triaged
Projects
None yet
Development

No branches or pull requests

6 participants