Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2 #8958

Closed
rainersigwald opened this issue Jun 26, 2023 · 2 comments · Fixed by #9060
Closed

TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2 #8958

rainersigwald opened this issue Jun 26, 2023 · 2 comments · Fixed by #9060
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Iteration:2023July triaged
Milestone
VS 17.8

Comments

@rainersigwald
Copy link
Member

After #8883, iTerm2 on macOS makes an audible alert sound and issues a toast notification that says Session dotnet #1: 4;0;. It looks like they're interpreting the status sequence as that instead of "start/stop spinner".

Terminal ignores the unknown code.
@rainersigwald rainersigwald added the Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. label Jun 26, 2023
@rainersigwald rainersigwald added this to the VS 17.8 milestone Jun 26, 2023
@rainersigwald
Copy link
Member Author

To mitigate this quickly, let's do it the easy way and just check OS before emitting these codes.

@slang25
Copy link

slang25 commented Jul 20, 2023

I switched this off this morning because it was bugging me 😄 I did it in macOS notification settings for iTerm specifically, but I can see this being annoying for many iTerms users.

vlada-shubina added a commit to vlada-shubina/msbuild that referenced this issue Jul 24, 2023
@vlada-shubina
fixes dotnet#8958 TerminalLogger in .NET 8.0.100-preview.6 issues aud…
c385d34 
…ible alerts on iTerm2
@vlada-shubina vlada-shubina mentioned this issue Jul 24, 2023
Merged
vlada-shubina added a commit to vlada-shubina/msbuild that referenced this issue Jul 24, 2023
@vlada-shubina
fixes dotnet#8958 TerminalLogger in .NET 8.0.100-preview.6 issues aud…
958a932 
…ible alerts on iTerm2
JaynieBai pushed a commit that referenced this issue Jul 28, 2023
@vlada-shubina
fixes #8958 TerminalLogger in .NET 8.0.100-preview.6 issues audible a…
ce59c70 
…lerts on iTerm2 (#9060)

fixes #8958

Context
TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2
Iterm2 treats ;9 code differently from ConEmu: https://iterm2.com/documentation-escape-codes.html

Changes Made
Disabled progress reporting on Mac

Testing
Tested manually on Mac

Notes
dotnet-bot pushed a commit to dotnet/dotnet that referenced this issue Jul 31, 2023
@dotnet-maestro
[msbuild] Sync 24ee0c7 → e2e438e
07d60a2 
Diff: https://github.com/dotnet/msbuild/compare/24ee0c75a7c5a9924c68157ae7f8e0ce6c9adca3..e2e438ef48eec8cf83d81cfc66cf3bb363ff5513

From: dotnet/msbuild@24ee0c7
To: dotnet/msbuild@e2e438e

Commits:
  - [main] Update dependencies from dotnet/arcade (#9059)
    dotnet/msbuild@881abda
  - Merge pull request #9066 from JanKrivanek/proto/tl-dotnettests-disable
    dotnet/msbuild@fd4d0e5
  - Add unit test for dotnet/msbuild#8870 (#8961)
    dotnet/msbuild@6c1bb22
  - fixes dotnet/msbuild#8958  TerminalLogger in .NET 8.0.100-preview.6 issues audible alerts on iTerm2 (#9060)
    dotnet/msbuild@ce59c70
  - TaskFactoryWrapper: guard against multi-threaded access to dictionaries (#8928)
    dotnet/msbuild@edeacbb
  - Resource for invalid -tl value (#9078)
    dotnet/msbuild@e2e438e

[[ commit created by automation ]]
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Terminal Logger Problems with the livelogger/fancylogger/terminallogger -tl functionality. Iteration:2023July triaged
Projects
None yet
Milestone
VS 17.8
3 participants
@slang25 @rainersigwald @AR-May