Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when glob expansion fails and falls back to literal #9609

Open
rainersigwald opened this issue Jan 5, 2024 · 2 comments
Open

Log when glob expansion fails and falls back to literal #9609

rainersigwald opened this issue Jan 5, 2024 · 2 comments
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. backlog Priority:2 Work that is important, but not critical for the release size:1 triaged

Comments

@rainersigwald
Copy link
Member

Is there some kind of switch to turn on logging for globbing failures?

Originally posted by @alexrp in #9606 (comment)

@rainersigwald rainersigwald added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. needs-triage Have yet to determine what bucket this goes in. labels Jan 5, 2024
@rainersigwald
Copy link
Member Author

rainersigwald commented Jan 5, 2024

This would address the "silence" part of #406. I don't think it should be opt-in, but it probably needs to be quiet enough to be effectively binlog-only.

@AR-May AR-May added Priority:2 Work that is important, but not critical for the release triaged backlog size:1 and removed needs-triage Have yet to determine what bucket this goes in. labels Jan 30, 2024
@Youssef1313
Copy link
Member

@rainersigwald These failures happen quite randomly, and having the logging to be binlog only may not help for all cases. We don't really know when it will fail that we enable build logging for that build.

There should at least be an opt-in way to enable even if not building with /bl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. backlog Priority:2 Work that is important, but not critical for the release size:1 triaged
Projects
None yet
Development

No branches or pull requests

3 participants