Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: including files with **\*.SomeExtension may not be expanded in some cases #9351

Open
Youssef1313 opened this issue Oct 20, 2023 · 9 comments
Labels
backlog blocked bug Priority:2 Work that is important, but not critical for the release triaged

Comments

@Youssef1313
Copy link
Member

Issue Description

See unoplatform/uno.templates#354

In csproj, we simply have <PRIResource Include="**\*.resw" />

Then, we run a target that adds these to AdditionalFiles as follows:

https://github.com/unoplatform/uno/blob/1c635068111de02977090c8379206a4caac40b3d/src/SourceGenerators/Uno.UI.SourceGenerators/Content/Uno.UI.SourceGenerators.props#L359

We end up with:

2>C:\Users\XXX.nuget\packages\uno.winui\5.0.0-dev.3568\buildTransitive\Uno.UI.SourceGenerators.props(366,66): error MSB4184: The expression "[System.IO.Path]::GetFullPath(*.resw)" cannot be evaluated. Illegal characters in path.

Steps to Reproduce

Not consistent, but detailed above.

Expected Behavior

**\*.resw should be expanded properly.

Actual Behavior

Error

Analysis

No response

Versions & Configurations

No response

@Youssef1313 Youssef1313 added bug needs-triage Have yet to determine what bucket this goes in. labels Oct 20, 2023
@jeromelaban
Copy link
Contributor

To add to this issue, here's the location where we include this item group. It's located inside an Otherwise block, if that's relevant.

@rainersigwald
Copy link
Member

rainersigwald commented Oct 20, 2023

Very likely to be #406. @nickrandolph are there any files under the project directory with paths longer than MAX_PATH (260 characters)? The intermittency might be because they appear under obj\ or bin\, maybe?

@jeromelaban
Copy link
Contributor

That's interesting, so properly excluding default bin/obj folders may be of help, thanks for the insights!

@AR-May
Copy link
Member

AR-May commented Oct 24, 2023

@jeromelaban please tell us if the suggestion from @rainersigwald does not work for you.

@AR-May AR-May added needs-more-info Issues that need more info to continue investigation. and removed needs-triage Have yet to determine what bucket this goes in. labels Oct 24, 2023
@jeromelaban
Copy link
Contributor

@AR-May we've not been able to validate that it's still happening, but we'll be able to soon, we'll let you know! Thanks for the follow-up.

@ghost ghost added the stale For issues that haven't had activity in some time. label Nov 25, 2023
@ghost
Copy link

ghost commented Nov 25, 2023

This issue is marked as stale because feedback has been requested for 30 days with no response. Please respond within 14 days or this issue will be closed due to inactivity.

@jeromelaban
Copy link
Contributor

@AR-May so far it's not been havening anymore, so we can close this issue. We'll comment further if it ever happens again, thanks!

@ghost ghost added needs-triage Have yet to determine what bucket this goes in. and removed stale For issues that haven't had activity in some time. labels Nov 27, 2023
@Youssef1313 Youssef1313 reopened this Apr 4, 2024
@Youssef1313
Copy link
Member Author

@AR-May
Copy link
Member

AR-May commented Apr 23, 2024

Team triage: this issue is currently blocked by #9609. We need to improve logging to be able to investigate.

@AR-May AR-May added backlog blocked Priority:2 Work that is important, but not critical for the release triaged and removed needs-triage Have yet to determine what bucket this goes in. needs-more-info Issues that need more info to continue investigation. labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog blocked bug Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Development

No branches or pull requests

4 participants