Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElementLocation optimisations #10029

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
776ec7a
Remove redundant GetHashCode calls
drewnoakes Apr 17, 2024
37def11
Remove redundant null check
drewnoakes Apr 17, 2024
cb6ec14
Update comment
drewnoakes Apr 17, 2024
093bee7
Null annotate ElementLocation
drewnoakes Apr 18, 2024
65ed4dd
Pack line and column values into four bytes
drewnoakes Apr 18, 2024
bb30e4f
Remove redundant validation
drewnoakes Apr 18, 2024
57e0d5b
Simplify LocationString construction
drewnoakes Apr 18, 2024
80c1ea2
Consolidate validation
drewnoakes Apr 18, 2024
3ea9a86
Simplify names (IDE0001)
drewnoakes Apr 18, 2024
075ce08
Use auto properties
drewnoakes Apr 18, 2024
2f1c078
Use inheritdoc to avoid duplication
drewnoakes Apr 18, 2024
28cfb19
Make field readonly
drewnoakes Apr 18, 2024
2acc628
Use constants
drewnoakes Apr 18, 2024
596c574
Reduce branching when testing line/column values
drewnoakes Apr 18, 2024
d461522
Use pattern matching
drewnoakes Apr 18, 2024
5ef2a4b
Use standard API doc prefix
drewnoakes Apr 18, 2024
2b81d60
Use primary constructor
drewnoakes Apr 18, 2024
fc82d47
Seal private nested classes
drewnoakes Apr 18, 2024
be277f6
Improve hash function
drewnoakes Apr 18, 2024
2653348
Revert field packing
drewnoakes Apr 18, 2024
efb2f9a
Inline field
drewnoakes Apr 19, 2024
4d4a4ee
Pack ElementLocation more efficiently on 64-bit architectures
drewnoakes Apr 22, 2024
e5ab818
Reset the file index before running ElementLocation tests
drewnoakes Apr 22, 2024
c47008b
Simplify test a bit
drewnoakes Apr 22, 2024
be049a8
Add test that shows file index packing
drewnoakes Apr 22, 2024
3fb49a8
Add comment
drewnoakes Apr 22, 2024
c3de378
More info in assertion message
drewnoakes Apr 22, 2024
a3af7bf
Fix assertion
drewnoakes Apr 22, 2024
eeed871
Update test code
drewnoakes Apr 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading