Create explicit logger forwarder for buildcheck #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Apr 30, 2024
Yeah - it's in my bucket list - but first I need to find the time to debug through the code back and forth - as there seems to be a bit more to it than publicly documented. For now the public documentation is what should siffice for basic knowledge: https://learn.microsoft.com/en-us/visualstudio/msbuild/writing-multi-processor-aware-loggers |
|
Measured perf of this fix. Results:
Despite this good numbers, the CPU of the main msbuild node still has a very considerable overhead when analyzers are on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #10068
Context
#9988 (comment) uncovered a perf regression with BuildCheck.
Portion of the regression was tracked to excessivbe logging of tasks (credit to @ladipro for the initial idea). This PR is trying to address the case.
Changes Made
BuildCheck is bringing in it's own forwarding logger - so that it can properly self-declare the minimum needed tasks verbosity (and in the future influence what events need to be transfered)
Testing
The verbosity integrations test
Pre-existing tests on BuildCheck