-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extending common DependsOn properties #10122
base: main
Are you sure you want to change the base?
Conversation
Looks good to me! |
@@ -84,7 +84,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
--> | |||
|
|||
<PropertyGroup> | |||
<CreateManifestResourceNamesDependsOn></CreateManifestResourceNamesDependsOn> | |||
<CreateManifestResourceNamesDependsOn>$(CreateManifestResourceNamesDependsOn)</CreateManifestResourceNamesDependsOn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just delete this one?
@@ -889,6 +889,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
--> | |||
<PropertyGroup> | |||
<BuildDependsOn> | |||
$(BuildDependsOn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this one scares me. It goes from "no effect" to "move your targets to the VERY BEGINNING of the list".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a larger question: you chose to prepend everywhere. Is that always right? I am suspicious.
Fixes #9755
Context
Allow extending common targets *DependsOn properties
It's a continuation of #4922 and #9703 - handling rest of the properties
Changes Made
All
*DependsOn
properties are defined in nondestructive wayTesting
Existing test
Notes
@ghogen - Once/If this is merged, I'd suggest the DependsOn properties to be prefered extension way over redefining targets from common target files (for https://github.com/MicrosoftDocs/visualstudio-docs-pr/pull/12564)
Dependencies that might possibly be usefull for powerusers to extend include:
Property
BuildDependsOn
RebuildDependsOn
RunDependsOn
CompileDependsOn
CreateSatelliteAssembliesDependsOn
CleanDependsOn
PostBuildEventDependsOn
PublishBuildDependsOn
ResolveAssemblyReferencesDependsOn