Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Unify Build and Graph OM and API #10172

Merged
merged 18 commits into from
Jul 4, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented May 24, 2024

Prerequisity for indicating Build Submissions in Build Events (which will be needed by BuildCheck to detect Restore)

Context

Build and Graph Build OM and API is largely duplicated. Building on top of this (e.g. to add 'BuildSubmissionStartedEventArgs') would require even further duplication of code.

So let's deduplicate the OM and API.

Changes Made

  • Unify Request, Result, Submission
  • Apply nullability checking on all refactored code
  • Unify the functionality in BuildManager
  • Apply nullability checking on whole BuildManager

Important notes:

FYI @dfederm - this is heavily touching graph requesting - so your PoV would be very helpful

JanKrivanek and others added 2 commits May 20, 2024 17:28
Co-authored-by: Mariana Dematte <magarces@microsoft.com>
@JanKrivanek JanKrivanek requested review from drewnoakes and removed request for drewnoakes June 6, 2024 17:58
@JanKrivanek JanKrivanek marked this pull request as ready for review June 6, 2024 17:59
src/MSBuild/XMake.cs Outdated Show resolved Hide resolved
@JanKrivanek
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JanKrivanek
Copy link
Member Author

rekicking CLA bot

@JanKrivanek JanKrivanek reopened this Jun 11, 2024
@JanKrivanek
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JanKrivanek
Copy link
Member Author

rekicking cla

@JanKrivanek JanKrivanek reopened this Jun 14, 2024
Copy link
Contributor

@maridematte maridematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but because there are so many changes to just nullable variables it gets harder to review this. Maybe all the nullable changes could have been in another PR just so we can focus on the functionality of the refactor.

src/Build/BuildCheck/Utilities/EnumerableExtensions.cs Outdated Show resolved Hide resolved
@JanKrivanek
Copy link
Member Author

Experimental VS insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/562572 (build goes fine now!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants