Add binlog message in case of failure to add embedded file #10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @KirillOsenkov |
JanKrivanek
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Looks good!
I left couple of comments for consideration.
It's fine to skip unit test here - but please make sure to simulate the scenario manually (e.g. under the debugger) to have a binlog produced and verify that the build finishes just fine and that the log can be opened in binlog viewer
|
I conducted a manual test for this fix: placed a breakpoint in AddFileCore and deleted the file which is being read in it. |
KirillOsenkov
approved these changes
Jun 7, 2024
|
@dotnet-policy-service rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9450
Context
in #9307 an empty catch was added in ProjectImportsCollector.cs
Changes Made
create an event that adds a low priority message if an exception occurs there
Testing
an exception in that place occurs only if weird things are happening with the files (e.g. they are edited while read)
did not manage to create an end-to-end test
looking for ideas to make an unit test
Notes