Fail the CI build if there are any uncommitted changes #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :: Detect if there are any changed files which should fail the build | ||
| if DEFINED JENKINS_URL ( | ||
| echo Detecting changed files... | ||
| git diff --cached HEAD --exit-code |
There was a problem hiding this comment.
Isn't a failure here ignored since you go to the next line?
There was a problem hiding this comment.
You could maybe do git diff --exit-code HEAD which should show all diffs between the work tree and HEAD.
Torn on --quiet versus --exit-code--it'd be nice to get a list on failure, so I guess I prefer --exit-code.
There was a problem hiding this comment.
I'm no git expert, but it worked when I tested it. I'm going to try this instead:
git --no-pager diff HEAD --word-diff=plain --exit-code which seems to work...
jeffkl
force-pushed
the
failonchanges
branch
4 times, most recently
from
5b2cf8a
to
b78ff40
Compare
AndyGerlicher
approved these changes
Jan 12, 2017
cdmihai
approved these changes
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll only be updating cibuild.cmd so ignore the other change as I'm using it to test this.