Replay #1793
Merged
Replay #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of specifying a project or solution, you can specify a .binlog file to "build" and it will replay all the events in the source log into the usual loggers.
|
@dotnet-bot test Windows_NT Build for Desktop please |
|
@dotnet-bot test Ubuntu16.04 Build for CoreCLR |
cdmihai
reviewed
Mar 7, 2017
| { | ||
| string code; | ||
| string helpKeyword; | ||
| var text = ResourceUtilities.FormatResourceString(out code, out helpKeyword, "InvalidLogFileFormat", ex.Message); |
There was a problem hiding this comment.
there appears to be a FormatResourceString overload that does not have the out params
cdmihai
reviewed
Mar 7, 2017
| ReplayBinaryLog(projectFile, loggers); | ||
| } | ||
| else // regular build | ||
| { |
There was a problem hiding this comment.
nit: The new else block is not indented.
cdmihai
approved these changes
Mar 7, 2017
|
There's already a test for replay here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary log replay functionality.
Instead of specifying a project or solution, you can specify a .binlog file to "build" and it will replay all the events in the source log into the usual loggers.
Note that BuildLogReplayEventArgs and its base class EventArgsDispatcher need to be made public for the replay functionality in MSBuild.exe to work. I've made the class sealed and added with explanations.