Fix crash parsing Clang/GCC messages with no text #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Clang/GCC-style error didn't have any text, an IndexOutOfRangeException exception was thrown. This guards against that. Unit tests for a normal Clang/GCC error and a degenerate one have been added. Fixes dotnet#1796
|
@chwarr, It will cover your contributions to all Microsoft-managed open source projects. |
cdmihai
approved these changes
Mar 8, 2017
|
@chwarr, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
rainersigwald
approved these changes
Mar 15, 2017
|
@dotnet-bot test this please (against new base branch) |
AndyGerlicher
approved these changes
Mar 15, 2017
|
Thanks for getting the CLA signed! |
|
@KirillOsenkov bin log failure with the extra artifact you added: https://ci2.dot.net/job/Microsoft_msbuild/job/master/job/_Windows_NT_Desktop_prtest/620/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Clang/GCC-style error didn't have any text, an
IndexOutOfRangeException exception was thrown. This guards against that.
Unit tests for a normal Clang/GCC error and a degenerate one have been
added.
Fixes #1796