Should not opt in the SHA-2 workaround for 3rd party crypto providers #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
force-pushed
the
dev/mattfei/EVCertIssue
branch
from
4adbaa0
to
a377b50
Compare
rainersigwald
approved these changes
Jul 12, 2017
There was a problem hiding this comment.
Pushed a space change so this will be a clean merge with #2290.
|
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/462908 was approved at shiproom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code modified in this PR is used by clickonce to sign the manifest file. In order to support signing with SHA-2 cert, a workaround was added. However, this workaround should be opted out for 3rd party crypto providers. Otherwise, it causes verification failure(unknown publisher) when the manifest file is signed by a SHA-2 EV cert.