Fixed a typo in TaskItemComparer #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed dotnet#81 (Courtesy of Viva64 and their PVS-Studio static analyzer. http://habrahabr.ru/company/pvs-studio/blog/268001/ )
|
Cannot build and add tests because of #224, sorry. Amended the commit message. |
|
Thanks for updating. Looks good to me as well, this really needs to be fixed. |
|
LGTM. And hopefully we've figured out #224--it looks like you need to add the VS feature that includes the Windows SDK to get our NuGet stuff to work. |
AndyGerlicher
added a commit
that referenced
this pull request
Oct 1, 2015
Fixed a typo in TaskItemComparer
Closed
radical
pushed a commit
to radical/msbuild
that referenced
this pull request
Jan 23, 2020
…0121.4 (dotnet#240) - Microsoft.Dotnet.Toolset.Internal - 3.1.200-preview.20071.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Courtesy of Viva64 and their PVS-Studio static analyzer. http://habrahabr.ru/company/pvs-studio/blog/268001/ )