Identify inner build in consuming project #2472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid batching the _GetProjectReferenceTargetFrameworkProperties target for each reference, the ProjectReference protocol can be amended to return an item from GetTargetFrameworkProperties instead of a semicolon-delimited list of key-value pairs. This allows a single build request to be sent to the engine, and allows resolving references in parallel on multiprocess builds.
The previous commit is a breaking change to the ProjectReference protocol, requiring a .NET Core SDK change to return the now-expected structured data rather than the old semicolon-delimited string. That means, for example, that MSBuild v15.5 couldn't build a solution containing a full framework project that referenced a .NET Core SDK 2.0.0 project. To avoid this, reconstruct the new structured data from the old return value: * Allow the MSBuild engine to split the returned value on `;` and return multiple values. * Batch over metadata common to those values to reconstruct a single item with the complete string return value. * Parse that string into structured metadata on a single item, as though the project had returned a single item with metadata. * Remove the now-redundant individual-valued items. * Continue as before with adjusting the reference items based on the metadata.
In preparation for describing the changes to return values I'd like to make, I need to document what the old ones were.
Document the more-succinct-but-compatibility-breaking single-item-with-metadata return possibility for GetTargetFrameworkProperties.
rainersigwald
commented
Aug 24, 2017
|
|
||
| ====================================================================================== | ||
| --> | ||
| <Target Name="_GetProjectReferenceTargetFrameworkProperties"> |
There was a problem hiding this comment.
This is no longer needed if the above multitargeting handling is comprehensive. If we go with the try-the-new-way-and-don't-fail-if-it-doesn't-work approach, it'd serve as the compat fallback.
rainersigwald
force-pushed
the
get-tf-compatibility-in-consumer
branch
from
23bdb14
to
09b99b6
Compare
|
Left to do:
|
AndyGerlicher
added a commit
to AndyGerlicher/msbuild
that referenced
this pull request
Sep 21, 2017
Add optional SkipMissingTargets property to the MSBuild task. This allows for the ability to make changes to our project to project reference protocol which would be an otherwise breaking change. Related to dotnet#2472 Closes dotnet#2471
AndyGerlicher
added a commit
to AndyGerlicher/msbuild
that referenced
this pull request
Sep 27, 2017
Add optional SkipMissingTargets property to the MSBuild task. This allows for the ability to make changes to our project to project reference protocol which would be an otherwise breaking change. Related to dotnet#2472 Closes dotnet#2471
AndyGerlicher
added a commit
to AndyGerlicher/msbuild
that referenced
this pull request
Sep 27, 2017
Add optional SkipNonexistentTargets property to the MSBuild task. This allows for the ability to make changes to our project to project reference protocol which would be an otherwise breaking change. Related to dotnet#2472 Closes dotnet#2471
Merged
|
Closing in favor of #2595 |
radical
pushed a commit
to mono/msbuild
that referenced
this pull request
Oct 25, 2017
Add optional SkipNonexistentTargets property to the MSBuild task. This allows for the ability to make changes to our project to project reference protocol which would be an otherwise breaking change. Related to dotnet#2472 Closes dotnet#2471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed ProjectReference protocol change and the required new target (+ dependency on NuGet.Frameworks).
This allows solving the double-evaluation-of-ProjectReferences problem by ensuring that a) every referencing project calls into the same cached
GetTargetFrameworks-with-no-TF-set evaluation of the reference, and b) single-targeted projects will use the same evaluation for their build.It is also cacheable, but that's not done here.
Builds on #2458, since that simplified the ProjectReference flow.