Introduce timeout to prevent a hang in CancelledBuild #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Apr 16, 2020
| @@ -1517,7 +1517,8 @@ public void CancelledBuild() | |||
|
|
|||
| asyncResult.ExecuteAsync(null, null); | |||
| _buildManager.CancelAllSubmissions(); | |||
| asyncResult.WaitHandle.WaitOne(); | |||
| asyncResult.WaitHandle.WaitOne(10000); | |||
There was a problem hiding this comment.
Suggested change
| asyncResult.WaitHandle.WaitOne(10000); | |
| asyncResult.WaitHandle.WaitOne(TimeSpan.FromSeconds(10)); |
I always prefer the explicit overload, so you don't have to remember units.
| @@ -1517,7 +1517,8 @@ public void CancelledBuild() | |||
|
|
|||
| asyncResult.ExecuteAsync(null, null); | |||
| _buildManager.CancelAllSubmissions(); | |||
| asyncResult.WaitHandle.WaitOne(); | |||
| asyncResult.WaitHandle.WaitOne(10000); | |||
There was a problem hiding this comment.
Comment the arbitrary timeout please.
Forgind
added a commit
to dotnet-maestro-bot/msbuild
that referenced
this pull request
Apr 24, 2020
Introduce timeout to prevent a hang in CancelledBuild, which failed recently.
sfoslund
pushed a commit
to sfoslund/msbuild
that referenced
this pull request
May 15, 2020
Introduce timeout to prevent a hang in CancelledBuild, which failed recently.
rainersigwald
added a commit
that referenced
this pull request
Oct 26, 2020
This was attempted in #5290 but we hit a hang in this test again this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards #5229.