Enable MSBuild building without 3.5 SP1 targeting pack installed. #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#5620. Unfortunately the Microsoft.NETFramework.ReferencesAssemblies does not include net35, so we're using https://www.nuget.org/packages/jnm2.ReferenceAssemblies.net35 combined with a workaround to bypass looking for System.Data.Entity.dll 3.5.0.0 in the GAC.
|
@jnm2 FYI, also thanks for saving the day. |
|
@KirillOsenkov msbuildlog.com saved my day a hundred times, so I'm just glad to be able to make a dent in the opposite direction 😊 |
Forgind
approved these changes
Aug 7, 2020
Forgind
added
the
merge-when-branch-open
benvillalobos
approved these changes
Aug 7, 2020
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Closing to reopen and trigger a CI build. See #5646 |
Forgind
pushed a commit
that referenced
this pull request
Feb 9, 2021
…6129) Fixes #6084 Context As a dependency of MSBuildTaskHost, StringTools is built for .NET 3.5, in addition to modern .NET Framework and .NET Core. Changes Made Made the project built on machines without the 3.5 targeting pack installed by setting BypassFrameworkInstallChecks, same as #5621. Testing Successfully built MSBuild on a clean VM without any 3.5 bits installed. Notes Thank you @KirillOsenkov Kirill Osenkov FTE for spotting this and suggesting the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5620.
Unfortunately the Microsoft.NETFramework.ReferencesAssemblies does not include net35, so we're using https://www.nuget.org/packages/jnm2.ReferenceAssemblies.net35 combined with a workaround to bypass looking for System.Data.Entity.dll 3.5.0.0 in the GAC.