Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths to solution items #5635

Merged
merged 1 commit into from Aug 14, 2020
Merged

Fix paths to solution items #5635

merged 1 commit into from Aug 14, 2020

Conversation

ostorc
Copy link
Contributor

@ostorc ostorc commented Aug 8, 2020

Small change which fixes paths to NuGet.Config and xunit.runner.json. This enables to open these files directly from VS (and other editors).

Fix paths to solution items
fb5ec0d 
This commit fixes path to NuGet.Config and xunit.runner.json.
@ostorc
Copy link
Contributor Author

ostorc commented Aug 10, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@benvillalobos
Copy link
Member

benvillalobos commented Aug 10, 2020 •
edited

Closing to reopen and trigger a CI build. See #5646.

@benvillalobos benvillalobos reopened this Aug 10, 2020
Forgind
Forgind approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although MSBuild.Dev.sln was updated with this fairly recently, I believe we just did whatever MSBuild.sln did, which was last updated more like 4 years ago. I could easily see them having moved around a bit since then.

benvillalobos
benvillalobos approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Forgind Forgind merged commit 0c56d8b into dotnet:master Aug 14, 2020
@ostorc ostorc deleted the slnPathFix branch August 14, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmihai cdmihai cdmihai approved these changes

@benvillalobos benvillalobos benvillalobos approved these changes

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ostorc @benvillalobos @cdmihai @Forgind