Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Synergy DBL to be a known supported type GUID #5159 #5698

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

madkat
Copy link
Contributor

@madkat madkat commented Sep 1, 2020

This PR adds another language to the list of project type guids considered as KnownToBeMSBuildFormat. Without presence in this list, newer features such as /graphBuild will silently exclude the language from participation (per #5159). Synergy DBL (*.synproj) conforms to the MSBuild Project Reference Protocol and is otherwise a compatible language other than being missing from this list.

@aolszowka
Copy link

+1 This Directly affects the workflows of our Company who services several large Industrial Gas Supply and Medical DME Equipment Providers.

Accepting this PR will resolve the linked issue (#5159) and allow us to start heavily testing the /graph implementation in our build systems.

@Forgind Forgind merged commit c7790e1 into dotnet:master Sep 4, 2020
@rainersigwald
Copy link
Member

Thanks @madkat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants