Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rich Code Navigation Indexing #5790

Merged
merged 9 commits into from Oct 13, 2020
Merged

Add Rich Code Navigation Indexing #5790

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21b3176
Add rich navigation specific pipeline
jepetty Oct 6, 2020
b909144
Fix build script
jepetty Oct 7, 2020
6d9cc00
Set environment variables
jepetty Oct 7, 2020
c43fdae
Add Rich Navigation to main debug build
jepetty Oct 9, 2020
576184e
Stop looking for output log files
jepetty Oct 9, 2020
8898c14
Update Rich Nav specific pipeline to not include the binary output flag
jepetty Oct 9, 2020
0faffd8
Alter pipelines to align more cleanly with msbuild defaults
jepetty Oct 12, 2020
167e210
Remove standalone richnav job
rainersigwald Oct 13, 2020
dc23c8a
Move richnav to shortest Windows leg
rainersigwald Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vsts-dotnet-ci.yml
View file
Open in desktop
Expand Up @@ -58,6 +58,11 @@ jobs:
inputs:
filename: 'eng/cibuild_bootstrapped_msbuild.cmd'
arguments: '-msbuildEngine dotnet'
- task: RichCodeNavIndexer@0
Copy link
Member

@Forgind Forgind Oct 12, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to only add this to the Core on Windows build? (As opposed to any of the others)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, mostly just picked a build :) We have a requirement to run on Windows, but otherwise no reason to do "Windows Core" over "Windows Full"

displayName: RichCodeNav Upload
inputs:
languages: 'csharp'
continueOnError: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add a condition?

- task: PublishTestResults@2
displayName: Publish .NET Framework Test Results
inputs:
Expand Down
21 changes: 21 additions & 0 deletions .vsts-dotnet-richnav.yml
View file
Open in desktop
@@ -0,0 +1,21 @@
trigger:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to also trigger for exp/* and vs*


jobs:
- job: BootstrapMSBuildOnFullFrameworkWindows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this name reference rich navigation? And not bootstrap?

displayName: "Rich Navigation Indexing"
pool:
vmImage: 'windows-2019'
variables:
EnableRichCodeNavigation: true
steps:
- task: Powershell@2
displayName: build
inputs:
filePath: eng/common/build.ps1
arguments: '-restore -build -ci /p:CreateBootstrap=false /nr:false'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
arguments: '-restore -build -ci /p:CreateBootstrap=false /nr:false'
arguments: '-restore -build -ci /nr:false'

(It's the default.)

- task: RichCodeNavIndexer@0
displayName: RichCodeNav Upload
inputs:
languages: 'csharp'
continueOnError: true