Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Cultures Within Names For EmbeddedResources #5824

Merged
merged 10 commits into from
Nov 23, 2020
Merged

Allow Cultures Within Names For EmbeddedResources #5824

merged 10 commits into from
Nov 23, 2020

Commits on Oct 21, 2020

  1. AssignCulture does not get called when an embeddedresource explicitly… 

    … defines 'false' for 'WithCulture' metadata
    @benvillalobos
    benvillalobos committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    004d287 View commit details
    Browse the repository at this point in the history

  2. GetCultureItemInfo respects 'WithCulture' metadata set to 'false'

    @benvillalobos
    benvillalobos committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    c12699d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Pass boolean rather than whole item

    @benvillalobos
    benvillalobos committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5e8308b View commit details
    Browse the repository at this point in the history

  2. Renaming of boolean 

    It's surprisingly difficult to find a good name that means "workaround for those that want to name their files with a culture but have those files not be treated as culture-specific files"
    @benvillalobos
    benvillalobos committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8928d23 View commit details
    Browse the repository at this point in the history

  3. Add test for retaining culture.

    @benvillalobos
    benvillalobos committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    1fbba6c View commit details
    Browse the repository at this point in the history

  4. PR feedback

    @benvillalobos
    benvillalobos committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    089b7c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Add argument names to createmanifestnameimpl tests. check boolean first

    @benvillalobos
    benvillalobos committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    3a8fd0a View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Test now uses correct 'vb' extension

    @benvillalobos
    benvillalobos committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    0c4eb25 View commit details
    Browse the repository at this point in the history

  2. Fix vb test. use cs culture, and vb file extension

    @benvillalobos
    benvillalobos committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    9636a53 View commit details
    Browse the repository at this point in the history

  3. Try removing subfolder from test

    @benvillalobos
    benvillalobos committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    2e1d965 View commit details
    Browse the repository at this point in the history