Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass EvaluationId to ProjectStarted event #5997

Merged
merged 1 commit into from Jan 4, 2021
Merged

Conversation

KirillOsenkov
Copy link
Member

It is very useful to associate ProjectStarted with the evaluation used for the build. We have the MS.B.E.ProjectInstance in ProjectLoggingContext, so pass that to LogProjectStarted.

Fixes #4926

It is very useful to associate ProjectStarted with the evaluation used for the build. We have the MS.B.E.ProjectInstance in ProjectLoggingContext, so pass that to LogProjectStarted.

Fixes #4926
@KirillOsenkov
Copy link
Member Author

Now we can correlate project builds with evaluations:
image

We will now also show accurate preprocessed XML because we will be using the right set of ProjectImported events to stitch together the final text depending on which project we're preprocessing.

Another thing I'm thinking is logging Properties and Items per evaluation, not per project. So if multiple projects were built using the same evaluation, we can log only once, saving time and space in the binlog.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this has been annoying me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project build should log which evaluation id corresponds to this project
3 participants