Don't compile globbing regexes on .NET Framework #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jun 28, 2021
benvillalobos
approved these changes
Jun 28, 2021
|
As a change in this PR, can you modify the list in https://github.com/dotnet/msbuild/blob/main/documentation/wiki/ChangeWaves.md? |
drewnoakes
reviewed
Jun 29, 2021
marcpopMSFT
added
the
merge-when-branch-open
ladipro
added a commit
that referenced
this pull request
Aug 28, 2023
Contributes to [AB#1811625](https://devdiv.visualstudio.com/0bdbc590-a062-4c3f-b0f6-9383f67865ee/_workitems/edit/1811625) ### Context Compiled regular expressions tend to run slower than interpreted ones on .NET Framework. Additionally, the cost of compiling is significant, especially on 64-bit. Here's a benchmark running `IsMatch("Microsoft.NET.Sdk")` against the only SDK regex we ship inbox: `^(?i)vcpkg:.*`. Note that it does not include the compilation, which is an additional one-time cost.  ### Changes Made Interpret `ResolvableSdkRegex` on .NET Framework. We made an analogous change to globbing some time ago in #6632. ### Testing Existing unit tests, targeted micro benchmark. ### Notes In the trace attached to the AzDO bug, this change eliminates 1/3 of the SDK resolution cost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6599
Context
Compiled regular expressions have a high first-call cost on .NET Framework, especially when running in a 64-bit process. At best, they need to be used thousands of times to make up for the compilation cost. In some cases compiled regexes are even slower than interpreted ones.
Changes Made
Switched regexes used in
MSBuildGlobto interpreted on .NET Framework. Also optimized capture groups as suggested by @ToddGrun and removed a couple of unused fields.Testing
MSBuildGlob.MatchInfoResult.