Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetPlatform: Use Platform Instead Of PlatformTarget #6889

Merged
merged 2 commits into from
Sep 27, 2021
Merged

SetPlatform: Use Platform Instead Of PlatformTarget #6889

merged 2 commits into from
Sep 27, 2021

Commits on Sep 24, 2021

  1. Pass and undefine Platform property 

    Instead of a mix between PlatformTarget and Platforms.
This fixes an issue with legacy projects that define values
for OutputPath and PlatformTarget based on the Platform|Configuration.
It also fixes an issue where a user can start a command line build by
passing /p:Platform=foo, and that global property would carry to ALL
p2p hops. This can lead to weird issues such as the Platform being x86
when a p2p hop might pass PlatformTarget=AnyCPU
    @benvillalobos
    benvillalobos committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    701f0fc View commit details
    Browse the repository at this point in the history

  2. Remove usage of PlatformTarget altogether

    @benvillalobos
    benvillalobos committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    8f353e2 View commit details
    Browse the repository at this point in the history