Minor allocation optimizations / cleanup #6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladipro
commented
Oct 22, 2021
| return existenceCache.Value.GetOrAdd(directory, Directory.Exists); | ||
| } | ||
|
|
||
| public virtual bool FileExists(string file) |
ladipro
commented
Oct 22, 2021
| p => FileUtilities.DirectoryExistsNoThrow(p), | ||
| (p, searchPattern) => Directory.GetDirectories(p, searchPattern), | ||
| p => AssemblyNameExtension.GetAssemblyNameEx(p), | ||
| (string path, ConcurrentDictionary<string, AssemblyMetadata> assemblyMetadataCache, out AssemblyNameExtension[] dependencies, out string[] scatterFiles, out FrameworkNameVersioning frameworkName) |
There was a problem hiding this comment.
I wonder if there's a more concise way of expressing this. My understanding is that if there is an out parameter then all parameters have to be listed complete with types.
rainersigwald
approved these changes
Oct 22, 2021
AR-May
approved these changes
Oct 22, 2021
Forgind
added
the
merge-when-branch-open
Forgind
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixing a few places where we allocated objects unnecessarily. This is by no means exhaustive.
Changes Made
GetOrAddshould be given a delegate to a method that creates a new object, not the new object itself. Otherwise we allocate and throw away the object in the "Get" case.Testing
Existing unit tests.