Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LockCheck on .NET on Windows #7436

Merged
merged 1 commit into from Apr 21, 2022

Conversation

rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Mar 3, 2022

Improves understandability of build issues like dotnet/sdk#9585. Fixes #7327

@rainersigwald
Copy link
Member Author

I built this initially on top of #6148 and it looks like that's a hard requirement, so leaving draft until that's done.

@rainersigwald
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rainersigwald rainersigwald marked this pull request as ready for review March 24, 2022 19:28
@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 11, 2022
src/Tasks/Copy.cs Outdated Show resolved Hide resolved
Fixes dotnet#7327 by supporting LockCheck on .NET 6 (behind a runtime OS
check).
@Forgind Forgind merged commit 4b78001 into dotnet:main Apr 21, 2022
@rainersigwald rainersigwald deleted the why-locked-on-core branch August 31, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Copy fails to copy a file, report which process is locking the file on .NET Core's msbuild
2 participants