Fix runsettings file generation in CI. #8161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
Is this a partial backport of #8085? It looks like it. If that's it: lgtm.
|
When looking at this offline, @Forgind asked if we should think about putting this in the oldest supported branch, then merging forward. Would that make sense? |
|
It makes sense, I created the PR #8189 to 16.11 we will let it flow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In order to be able to collect optimization data for this branch using the opt-prof v2 pipeline, we need to update the runsettings file generation. The generation happens during the CI build.
Changes Made
.runsettingsfile was updated by using the custom template in the run settings generation task (instead using the default one). The default template used by the task is located here. I took it and updated with theVisualStudioConfigurationelement. This element derived from valueVSINSTALLATIONTYPE = optproffrom the legacy OptProf pipeline.Testing
Experimental run of the opt-prof v2.