Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect .NET SDK & VSLANG Custom Language Settings & Apply To MSBuild #8503

Merged
merged 33 commits into from
May 12, 2023
Merged

Detect .NET SDK & VSLANG Custom Language Settings & Apply To MSBuild #8503

merged 33 commits into from
May 12, 2023

Commits on Feb 28, 2023

  1. Add logic to change the encoding and detect .NET SDK and VS language … 

    …settings.
    @nagilson
    nagilson committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    0f58db2 View commit details
    Browse the repository at this point in the history

  2. Restore the original encoding so msbuild does not impact encoding of … 

    …other programs on the same console.

Note that we could probably do this better. I tried to create a function to do so but because the SetConsoleUI is static this was the least ugly/simple way to do it.
Open to other proposals.
    @nagilson
    nagilson committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    3a3db4d View commit details
    Browse the repository at this point in the history

  3. Add a unit test for external ui language overrides

    @nagilson
    nagilson committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    e4595a9 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into nagilson-cli-language

    @nagilson
    nagilson committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    dc17603 View commit details
    Browse the repository at this point in the history

  5. Fix the merge conflict that vscode did not fix (grumpiness)

    @nagilson
    nagilson committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    fa715d1 View commit details
    Browse the repository at this point in the history

  6. Use langword=null for Sandcastle and VsDocMan 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @nagilson @rainersigwald
    nagilson and rainersigwald committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    cc30ce9 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Respond to feedback. But it's not done yet.

    @nagilson
    nagilson committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1058b59 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Limit the scope of the breaking change so windows who dont support ut… 

    …f8 dont get it by default unless opted in and introduce encoding restorer to prevent msbuild from changing the encoding.
    @nagilson
    nagilson committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    01b381b View commit details
    Browse the repository at this point in the history

  2. Remove comment that I didn't hit ctrl S on, automatic encoding restor… 

    …er takes care of this
    @nagilson
    nagilson committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    8487af6 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Move encoding restorer to a non public API 

    Co-Authored-By: Forgind <12969783+Forgind@users.noreply.github.com>
    @nagilson @Forgind
    nagilson and Forgind committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    747ff0b View commit details
    Browse the repository at this point in the history

  2. Use a name instead of _ for the discard variable bc the compiler gets… 

    … confused
    @nagilson
    nagilson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3b3b23d View commit details
    Browse the repository at this point in the history

  3. Dont use runtimeinfo as its not in net 472 full framework even tho it… 

    …s doced as being in net 472
    @nagilson
    nagilson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    d52714b View commit details
    Browse the repository at this point in the history

  4. Move the encoding restorer so it's not part of a public api and build… 

    …s for net 472
    @nagilson
    nagilson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b20919f View commit details
    Browse the repository at this point in the history

  5. Consider that full framework must set all culture variables for corre… 

    …ct behavior
    @nagilson
    nagilson committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8d0e14b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Try to make full framework correctly change the culture :(

    @nagilson
    nagilson committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    d96551c View commit details
    Browse the repository at this point in the history

  2. Check to see if the windows version of build machines doesnt support … 

    …utf 8
    @nagilson
    nagilson committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    9b1c074 View commit details
    Browse the repository at this point in the history

  3. Dont look for vslang because vs can manage the lang settings itself a… 

    …lready and also fix a test to use en because bild machines are apparently in french sometimes???
    @nagilson
    nagilson committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    5a06292 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Make the encoding change happen earlier than msbuild use server stuff

    @nagilson
    nagilson committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    60ee6bc View commit details
    Browse the repository at this point in the history

  2. Code clean up for dotnet cli language feature

    @nagilson
    nagilson committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    992fb7e View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Respond to PR feedback

    @nagilson
    nagilson committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    048bd20 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Follow the Microsoft style of using the string alias over System.String 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @nagilson @rainersigwald
    nagilson and rainersigwald committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    18f34d5 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. prepare to add encoding change to logs as well

    @nagilson
    nagilson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    881305c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into nagilson-cli-language

    @nagilson
    nagilson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    cfe0c6c View commit details
    Browse the repository at this point in the history

  3. Get the encoding to change log files as well and move the encoding up… 

    … before a debugger is attached so that build errors wont have a bad encoding
    @nagilson
    nagilson committed May 4, 2023
    Configuration menu
    Copy the full SHA
    45961ed View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Merge remote-tracking branch 'upstream/main' into nagilson-cli-language

    @nagilson
    nagilson committed May 9, 2023
    Configuration menu
    Copy the full SHA
    3023308 View commit details
    Browse the repository at this point in the history

  2. Add environment variable to disable/opt-out of the new feature

    @nagilson
    nagilson committed May 9, 2023
    Configuration menu
    Copy the full SHA
    41d9da6 View commit details
    Browse the repository at this point in the history

  3. Move the utf8 encoding change feature flag to the change wave

    @nagilson
    nagilson committed May 9, 2023
    Configuration menu
    Copy the full SHA
    aa5a55b View commit details
    Browse the repository at this point in the history

  4. Remove some no-longer-required usings

    @rainersigwald
    rainersigwald committed May 9, 2023
    Configuration menu
    Copy the full SHA
    5c2db93 View commit details
    Browse the repository at this point in the history

  5. Remove the english language and redirect in the help link 

    Co-authored-by: Forgind <12969783+Forgind@users.noreply.github.com>
    @nagilson @Forgind
    nagilson and Forgind committed May 9, 2023
    Configuration menu
    Copy the full SHA
    28b8bd0 View commit details
    Browse the repository at this point in the history

  6. Consider that a user may delete windows registry keys

    @nagilson
    nagilson committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e61c559 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'nagilson-cli-language' of https://github.com/nagilson/m… 

    …sbuild into nagilson-cli-language
    @nagilson
    nagilson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    16a0acd View commit details
    Browse the repository at this point in the history

  2. update test to expect the fallback culture instead of the original cu… 

    …lture as the existing code could change the culture to the fallback culture instead of the original culture
    @nagilson
    nagilson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f794639 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into nagilson-cli-language

    @nagilson
    nagilson committed May 10, 2023
    Configuration menu
    Copy the full SHA
    86cf4e5 View commit details
    Browse the repository at this point in the history