New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reënable static graph restore #8856
Conversation
This reverts commit 7c4d75d.
I think the failure may be a bad interaction with #8488. @JanKrivanek can you investigate as a kitten task (but super low pri, and feel free to delegate back to me if you're swamped :)). |
Adding to the kitten queue |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The error in this PR as below ever appeared in #8488 (comment). It's supposed src\MSBuild.Bootstrap\RedirectNuGetConsoleProcess.After.Microsoft.Common.targets could redirect the dotnet path properly. But from binlog Build.zip the task was not executed. No idea why.
|
@GangWang01 The target is defined as |
What is importing that .targets file? |
It's copied to |
Interesting that the build seems to fail in the non-bootstrapped legs - which should be independent on the other change (adressing bootstrap). |
The difference is in the Restore target that's being executed. For failed case it's comming from |
That pulls it in for projects that import common.targets, but not for solutions. @GangWang01 can you please try putting a copy of that file in |
It worked. #8960 fixed the failure. Please help to merge it to the work branch in this PR. |
…NuGet.RestoreEx.targets (#8960)
Thanks @GangWang01. LGTM (but it's my change too, so I'm not going to hit merge until somebody else looks at the current state). |
LGTM. It has enough approvals - I'm merging it now |
Reverts #8498 which should no longer be necessary now that 17.6 has rolled out broadly--it's everywhere I checked (official build, hosted agents, the pre queue).