-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/source-build-reference-packages #8893
[main] Update dependencies from dotnet/source-build-reference-packages #8893
Conversation
…ence-packages build 20230615.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23315.1
This is addressing dotnet/source-build#3494 (and by extension our false positive CG issue: https://devdiv.visualstudio.com/DevDiv/_componentGovernance/DotNet-msbuild-Trusted/alert/7824363?typeId=7350956&pipelinesTrackingFilter=0) |
…ence-packages build 20230616.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23316.2
Transfering discussion from dotnet/sdk#33388, per the last comment:
@MichaelSimons I very appreciate your detailed look and help! I appologize, but I have hard time understanding the above message. Are you saying that MSBuild references ConfigurationManager 7.0.0, but SRBP v8 have a version 8.x, so either MSBuild should reference CM 8.x or add v 7.0.0 to it's source pre-builds? As I believe we cannot reference 8.x packages due to the need to be inserted to VS. As for the other option - I belieive this is already hapening: https://github.com/dotnet/msbuild/blob/main/eng/SourceBuildPrebuiltBaseline.xml#L19 But with my very shallow knowledge of SourceBuild and MSBuild build I might be just misunderstanding you - in such case can you try to elaborate further or point me to info source where I can learn about the rootcause of this issue? |
…ence-packages build 20230619.4 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23319.4
The microsoft build and the repo level source-build CI references 7.0.0, but in the full product source build, the 8.x version is referenced.
I figured that was the case. Since this is already in the prebuilt baseline, then there shouldn't be anything else needed for ConfigurationManager. |
Hmm - I however still see the missing ConfigurationManager types errors in the sourcebuild binlong ( I know we should update to arcade8 to tackle the other issue (clashing types from |
Where are you seeing the CS0616 error? I am not seeing in the output of the source-build leg in this PR. |
Oh sorry - I haven't noticed there was a recent maestro push that resolved this. It happened only with the SBRP v 8.0.0-alpha.1.23316.2 (run https://github.com/dotnet/msbuild/runs/14343270323) |
Thanks for clarifying, that is what I was expecting. That package was recently removed because it wasn't being referenced in the product source-build. |
Once this is fixed - we should remove |
…ence-packages build 20230619.4 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23319.4
…ence-packages build 20230623.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23323.1
…ence-packages build 20230626.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23326.1
…ence-packages build 20230628.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23328.2
…ence-packages build 20230629.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23329.1
…ence-packages build 20230630.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23330.2
…ence-packages build 20230705.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23355.1
…ence-packages build 20230706.4 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23356.4
…ence-packages build 20230710.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23360.2
…ence-packages build 20230711.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23361.1
…ence-packages build 20230712.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23362.3
…ence-packages build 20230712.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23362.3 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 1.1.0-beta-21480-02 -> To Version 8.0.0-beta.23211.2 (parent: Microsoft.DotNet.Arcade.Sdk
…ence-packages build 20230718.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23368.2
…ence-packages build 20230721.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 7.0.0-alpha.1.23219.1 -> To Version 8.0.0-alpha.1.23371.1
…ence-packages build 20230724.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23374.3
…ence-packages build 20230728.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23378.3
…ence-packages build 20230731.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23368.2 -> To Version 8.0.0-alpha.1.23381.3
This pull request updates the following dependencies
From https://github.com/dotnet/source-build-reference-packages
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format